[Bug] with unit experience cap

[asamorodov]

Hi,

I guess that there is a bug in interaction between Leader's military skill and unit's experience cap.
As far as I can see the idea was that experience points count for separate unit is not changed when new leader is in game but different count of XP is needed to reach experience level depends on military skill of leader.
The problem is when unit reached his XP cap. For example for Spartan Phalanx it's necessary to have 150 XP to be elite if leader has no (neutral) military skill. But if leader has 'very good' military skill then only 105 XP is necessary. But because it's cap, XP count is truncated, and unit loses 45 XP but still is elite. And if after this leader we have leader with lesser military skill then we discover that our elite troop are elite no more

Leader 1, no military skill: 150 XP Elite unit
Leader 2, very good military skill: 105 XP Elite unit - still ok
Leader 3, no military skill: 105 XP Veteran unit - ooops, where is my elite troops?

Therefore we have paradoxical situation: if you have elite troops then coming of leader with good military skill is bad, because you get nothing (your troops are top already), but next leader with lesser military skill makes your troops worse.

The solution could be don't truncate XP or truncate it by biggest count of XP is necessary to be elite in worst case (worst military skill of leader).

[13obo]

Good spot! That does sound like a proper bug (and well explained too).