Stauffenberg wrote:I found and fixed the oil bug. This was actually a vanilla CeaW bug.
You've probably noticed that if a major power surrenders then their oil reserve is removed from the faction leader oil reserve. This can typically be seen when France surrenders. The Allied oil levels drops with about 200 oil.
Normally Italy has a small oil reserve when they surrender so they drop the Axis oil reserve slightly.
In Ronnie's game the Italians had a negative oil reserve of -170 and Germany a positive of 320. The Axis oil reserve is 150. So when Italy surrendered the Italian negative reserve was removed and the Germans ended up with 320.
I've changed the code so if a surrendering country has a negative oil reserve then the faction leader oil reserve will be reduced by that amount. Prior to the surrender you can say that Germany has lent oil to Italy and thus the Axis oil reserve is lower than Germany's oil reserve.
Borger, Nice find and fix.
One question (and possibly recommendation). What would have happened if Germany had surrendered? Would Italy's oil reserve go to -170. If so, I recommend that it can't fall below 0.