surrender bug in gs 2.1

[DukeOfLight]

altrough with the soviets i conquer the 3 cities of italy, italy surrendered to UK
After i took Berlin with the soviets, Hamburg was already in uk hands, germany surrendered to UK
is this ok? i can provide you with the save in case there are some unbelievers

[Kragdob]

Romania and Bulgaria also surrenders to UK. This is the game unfortunately.

[Morris]

Yes , Slitherine is from UK .

[DukeOfLight]

ok...i can live with that...

[JimR]

Rule Britannia!

[Peter Stauffenberg]

The code since the vanilla game is that if a major country surrenders the controlling country will be the faction leader of a side.

The sequence of faction leaders are:

Axis:
1. Germany if not surrendered
2. Italy

Allies:
1. UK if not surrendered
2. USA if not surrendered
3. USSR

Regarding the Allies I think UK was set as the primary faction leader since they are at war from the start of the game. The faction leader gets the income and will take control of the conquered country's hexes.

This is probably done because sometimes a minor country can first enter a capital and they shouldn't get the income of the conquered country. So the code makes it easy and let the faction leader get the conquer. Otherwise you need a transfer list saying which minor country to transfer their income to which faction leader.

I don't think this is a big issue. For the Axis it seems normal that Germany should get the income since they're the major Axis power. For the Allies one could discuss what to do, but USSR rarely forces surrenders. Their neighbouring countries will switch side of sign an armistice. It's the situation with Italy that seems a bit weird, but it happens very seldom. Usually the western Allies land in Italy before Russia even gets to the Balkans so they can move into Italy.

When Germany surrenders it's only a matter of time until the Axis surrenders so it's not important if Germany surrenders to UK or USSR. In the real war Germany surrendered when Hamburg fell, not Berlin. Hamburg most often falls to the western Allies. UK in the real war.

So I don't think it's necessary to add code to change these situations and risk introducing bugs. The code was added in the vanilla game for a reason and I'm a bit afraid of removing the faction leader principle from the code.

[Morris]

I don't fully accept Borger's explaination especially the Allies part , but anyway I can live with that since it usually become meaningless when it happens .

[Peter Stauffenberg]

I said I'm speculating why it was chosen in the vanilla. However, it is what it is.

[Peter Stauffenberg]

In GS v3.0 you get different surrender messages so this is not an issue. Control of the hexes will go to the conquering country. E. g. if USSR conquers Germany then the PP income from Germany will go to USSR and not UK.

[Morris]

In GS v3.0 you get different surrender messages so this is not an issue. Control of the hexes will go to the conquering country. E. g. if USSR conquers Germany then the PP income from Germany will go to USSR and not UK.

sounds great !