Possible save file corruption if used v2.00.08

[Peter Stauffenberg]

I just want all of you who played a turn using v2.00.08 to verify that all units you have on the map is working OK after you implemented v2.00.09.

The reason is that the change that was made to the method removeFromMap caused some problems. So if a country surrendered then removeFromMap is used or if a paratrooper unit is moved or a ferry crossing is done.

In one of my games the paratrooper unit couldn't move at the beginning of the turn. The unit was on the map, but the game didn't recognize it as an active unit.

In another of my games then Norway surrendered and a Norwegian garrison still remains in Norway adjacent to Oslo after surrender.

So to avoid any problems you could consider replaying turns made with v2.00.08.

The reason for the bug is that the original vanilla version of removeFromMap actually didn't remove the unit, but set the hex number to -1 (outside the map). So the statistics showed way too many units of each type because it also counted the fake units outside the map. So I added code that removed the unit from the unit list completely. That should have worked, but instead it crashed the 1941 scenario and caused the errors I explained above.

I didn't find a reason why this is happening so I removed the changed code so removeFromMap works as before just to avoid any problems. Instead I changed the code for statistics so it doesn't count units in hex -1. That means the statistics show the correct values.