Issue with Convoys in GS 1.05

[KingHunter3059]

This is for the BJR Development team and maybe for the Slitherine and Firepower folks as well. I am having fantastic luck in a game as the Allies, first of all. It is early 1942, and I have taken Italy and am pressing on Warsaw, but my British Convoys have stalled. My Russian convoys are still moving though. Is there a setting in the general.txt file that would prevent those convoys from moving? They are all stalled at the origination point. Thanks for your input!


Jay

[rkr1958]

This is for the BJR Development team and maybe for the Slitherine and Firepower folks as well. I am having fantastic luck in a game as the Allies, first of all. It is early 1942, and I have taken Italy and am pressing on Warsaw, but my British Convoys have stalled. My Russian convoys are still moving though. Is there a setting in the general.txt file that would prevent those convoys from moving? They are all stalled at the origination point. Thanks for your input!


Jay

We have fixed several issues with convoy in GS that were present in the vanilla game. I think this was one of the issues we addressed too. However; in a game I'm playing against Joe Rock I've noticed that I have two convoys each stacked up at the northern and central originating points. I just noticed that last turn and I wanted to play a couple more turns before I get too excited about it to see what happens.

[KingHunter3059]

This is for the BJR Development team and maybe for the Slitherine and Firepower folks as well. I am having fantastic luck in a game as the Allies, first of all. It is early 1942, and I have taken Italy and am pressing on Warsaw, but my British Convoys have stalled. My Russian convoys are still moving though. Is there a setting in the general.txt file that would prevent those convoys from moving? They are all stalled at the origination point. Thanks for your input!


Jay

We have fixed several issues with convoy in GS that were present in the vanilla game. I think this was one of the issues we addressed too. However; in a game I'm playing against Joe Rock I've noticed that I have two convoys each stacked up at the northern and central originating points. I just noticed that last turn and I wanted to play a couple more turns before I get too excited about it to see what happens.

Thanks Ronnie - Will let a few more turns pass, and let you know what is happening.

Jay

[KingHunter3059]

This is for the BJR Development team and maybe for the Slitherine and Firepower folks as well. I am having fantastic luck in a game as the Allies, first of all. It is early 1942, and I have taken Italy and am pressing on Warsaw, but my British Convoys have stalled. My Russian convoys are still moving though. Is there a setting in the general.txt file that would prevent those convoys from moving? They are all stalled at the origination point. Thanks for your input!


Jay

We have fixed several issues with convoy in GS that were present in the vanilla game. I think this was one of the issues we addressed too. However; in a game I'm playing against Joe Rock I've noticed that I have two convoys each stacked up at the northern and central originating points. I just noticed that last turn and I wanted to play a couple more turns before I get too excited about it to see what happens.

Thanks Ronnie - Will let a few more turns pass, and let you know what is happening.

Jay

Humm - we are in the spring of 42 and my convoys are still stuck. Do you all have any solutions in mind? Let me know....


Jay

[schwerpunkt]

Does your opponent have any SUBs near the convoy arrival or termination points?

[rkr1958]

KingHunter, All,

Apparently the reason that the convoys were not moving in both our games was due to a "nested if" code bug in the Game.class, which was intended to check if any of the choke points defined in the "general.txt" file were occupied by an axis ship or sub. Before this "fix" convoys would stack up off the coast Ireland and England if axis naval or sub units occupied these hexes. However; we introduced a bug in this fix where if these hexes were occupied by an allied naval or sub unit then the convoys would stall.

The second screen cap shows the situation in my game against Joe where a UK BB is occupying one of the choke points. I would suspect that KingHunter also has a surface or sub occupying that one or one of the others. By the way, if you wish to convert the choke hex coordinate (or any other one) to an (x,y), which is shown when you move your cursor over a hex, the equation is:

x = floor(c/72) and y = c -72x, where c = coordinate.





For patch see: viewtopic.php?p=148909#148909

[KingHunter3059]

Outstanding - You guy's are the best!


Jay

[KingHunter3059]

KingHunter, All,

Apparently the reason that the convoys were not moving in both our games was due to a "nested if" code bug in the Game.class, which was intended to check if any of the choke points defined in the "general.txt" file were occupied by an axis ship or sub. Before this "fix" convoys would stack up off the coast Ireland and England if axis naval or sub units occupied these hexes. However; we introduced a bug in this fix where if these hexes were occupied by an allied naval or sub unit then the convoys would stall.

The second screen cap shows the situation in my game against Joe where a UK BB is occupying one of the choke points. I would suspect that KingHunter also has a surface or sub occupying that one or one of the others. By the way, if you wish to convert the choke hex coordinate (or any other one) to an (x,y), which is shown when you move your cursor over a hex, the equation is:

x = floor(c/72) and y = c -72x, where c = coordinate.





For patch see: viewtopic.php?p=148909#148909

-
Thanks for your hard effort, however I found that the bottleneck hexes did not contain any Enemy or Friendly Naval units, but one errant convoy. Also, when I went to test the new game file in an AI game, I found that my PP levels dropped by 50 points every time as the british.

Jay

[Peter Stauffenberg]

The bug meant that if ANY Allied unit were in the bottleneck hexes then no convoys would move. That included convoys and transports.

[KingHunter3059]

The bug meant that if ANY Allied unit were in the bottleneck hexes then no convoys would move. That included convoys and transports.

Thanks Borger, but the problem persist. I guess this game is shot from this experience... I will monitor my other games as well...

Jay

[Peter Stauffenberg]

Can you send the save game to Ronnie or me?

Are you sure you placed the updated game.class file to the correct folder? There are 2 places to place it (one for the vanilla game and one for the GS mod),

Can you try to start a new game solo and move Allied naval units to the same locations as the existing game?

[KingHunter3059]

Can you send the save game to Ronnie or me?

Are you sure you placed the updated game.class file to the correct folder? There are 2 places to place it (one for the vanilla game and one for the GS mod),

Can you try to start a new game solo and move Allied naval units to the same locations as the existing game?

Two Places? I put it in the game folder - Is there another place???
If so, I will put it there and wait for the next turn - We seem to be playing all turns on the weekend...


Jay

[Peter Stauffenberg]

There are two game folders:
C:\Program Files\Slitherine\Commander - Europe At War\game (wrong folder)
C:\Program Files\Slitherine\Commander - Europe At War\Grand Strategy Mod\game (correct folder)

The former is for the vanilla game and the latter for GS.

[KingHunter3059]

There are two game folders:
C:\Program Files\Slitherine\Commander - Europe At War\game (wrong folder)
C:\Program Files\Slitherine\Commander - Europe At War\Grand Strategy Mod\game (correct folder)

The former is for the vanilla game and the latter for GS.

<sigh> I did put it in the GS Mod Game folder... How do you want me to send you and/or ronnie the game file? Do you want to PM me with your EMAIL? or Ronnie do you want to PM me as well? Should it be ready with the allies turn? Let me know...


Jay

[rkr1958]

There are two game folders:
C:\Program Files\Slitherine\Commander - Europe At War\game (wrong folder)
C:\Program Files\Slitherine\Commander - Europe At War\Grand Strategy Mod\game (correct folder)

The former is for the vanilla game and the latter for GS.

<sigh> I did put it in the GS Mod Game folder... How do you want me to send you and/or ronnie the game file? Do you want to PM me with your EMAIL? or Ronnie do you want to PM me as well? Should it be ready with the allies turn? Let me know...


Jay

Just a minor, but significant point. For the patch to work it must be applied by the axis player since allied convoys move at the end of the axis turn.

[rkr1958]

There are two game folders:
C:\Program Files\Slitherine\Commander - Europe At War\game (wrong folder)
C:\Program Files\Slitherine\Commander - Europe At War\Grand Strategy Mod\game (correct folder)

The former is for the vanilla game and the latter for GS.

<sigh> I did put it in the GS Mod Game folder... How do you want me to send you and/or ronnie the game file? Do you want to PM me with your EMAIL? or Ronnie do you want to PM me as well? Should it be ready with the allies turn? Let me know...


Jay

Just a minor, but significant point. For the patch to work it must be applied by the axis player since allied convoys move at the end of the axis turn.

KingHunter, any word on this? We're wanting to release this patch to Iain so he can include it in the v1.05 installer; however, we're waiting to see if we still have a bug or if this is happening because your axis opponent hasn't applied the patch yet.

[KingHunter3059]

Sorry Ronnie -

I should have reported earlier, but I just got back in town. My Opponent updated his game file and it seems that the convoys got un-stuck! Thanks for the help.

Jay