It is usually advantageous not to line the edge of the terrain feature unless you gain an advantage from having the enemy fighting in open terrain, one example being an additional cohesion test penalty if they lose to heavy or determined foot.